Skip to content

CORS-4244: adjust validations to allow dual-stack CIDRs on AWS #10241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tthvo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CORS-4244: adjust validations to allow dual-stack CIDRs on AWS #10241

tthvo wants to merge 2 commits into from
+217 −18

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 20, 2026

Adjust the static validation to allow defining both IPv4 and IPv6 CIDR entries for clusterNetwork, serviceNetwork and machineNetwork only if platform.aws.ipFamily is specified as DualStackIPv4Primary or DualStackIPv6Primary.

Additional details

For AWS, the IPv6 machineNetwork CIDR may not be available in advance (i.e. before infra provisioning). For example, if the installer creates the VPC, the IPv6 CIDR by default is allocated automatically by AWS.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026 •
edited by openshift-ci bot
Loading

@tthvo: This pull request references CORS-4244 which is a valid jira issue.

Details

In response to this:

Adjust the static validation to allow defining both IPv4 and IPv6 CIDR entries for clusterNetwork, serviceNetwork and machineNetwork only if platform.aws.ipFamily is specified as DualStackIPv4Primary or DualStackIPv6Primary.

Additional details

For AWS, the IPv6 machineNetwork CIDR may not be available in advance (i.e. before infra provisioning). For example, if the installer creates the VPC, the IPv6 CIDR by default is allocated automatically by AWS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and sadasu January 20, 2026 06:59
@tthvo
Copy link
Member Author

tthvo commented Jan 20, 2026

/label platform/aws
/cc @patrickdillon @yunjiang29 @barbacbd

sadasu
sadasu reviewed Jan 20, 2026
View reviewed changes
@tthvo
Copy link
Member Author

tthvo commented Jan 20, 2026

/test golint

@tthvo
Copy link
Member Author

tthvo commented Jan 20, 2026

/test e2e-metal-ipi-ovn-ipv6 e2e-metal-ipi-ovn-dualstack e2e-openstack-dualstack

@tthvo
Copy link
Member Author

tthvo commented Jan 21, 2026

/test e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026 •
edited
Loading

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-dualstack 744091b link false /test e2e-openstack-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu
Copy link
Contributor

sadasu commented Jan 22, 2026

/approve

e2e-aws-ovn is failing due to openstack-installer-amd64 failing.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
barbacbd
barbacbd reviewed Jan 26, 2026
View reviewed changes
@barbacbd
Copy link
Contributor

barbacbd commented Jan 26, 2026

/retest-required

tthvo added 2 commits January 26, 2026 15:13
@tthvo
CORS-4244: adjust validations to allow dual-stack CIDRs on AWS
db146f4 
Adjust the static validation to allow defining both IPv4 and IPv6 CIDR
entries for clusterNetwork, serviceNetwork and machineNetwork.

Note: for AWS, the IPv6 machineNetwork CIDR may not be available in
advance. For example, if the installer creates the VPC, the IPv6 CIDR by
default is allocated automatically by AWS.
@tthvo
tests: add validation unit tests for dual-stack CIDR entries on AWS
6f91c00
@tthvo
Copy link
Member Author

tthvo commented Jan 26, 2026

In the latest commits, I added a validation to catch the case: ipFamily is dual-stack but serviceNetwork has only either IPv4 or IPv6. The message directs the user to specify dual-stack service CIDRs, which then existing dual-stack network validations (i.e. entry order, both IPv4/IPv6 CIDR exist) apply.

barbacbd
barbacbd reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@yunjiang29 yunjiang29 Awaiting requested review from yunjiang29

2 more reviewers

@sadasu sadasu sadasu left review comments

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@barbacbd barbacbd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/aws

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tthvo @openshift-ci-robot @sadasu @barbacbd